jarno
/
hydroxide-push
1
0
Fork 0
Code Issues Pull Requests Wiki Activity

update usage help to correct flag-command order 

Hi, I had a problem where the suggested usage is not actually how hydroxide was able to parse flags.

Currently, `hydroxide help` claims the correct order is
`usage: hydroxide <command> <flags>`

However, my flags are silently ignored when placing them in that order.
```
# hydroxide serve -smtp-port 2024
2020/07/01 01:43:20 CardDAV server listening on 127.0.0.1:8080
2020/07/01 01:43:20 SMTP server listening on 127.0.0.1:1025
2020/07/01 01:43:20 IMAP server listening on 127.0.0.1:1143
```

So I goofed with it a while and found out that hydroxide will not ignore flags if they go *before* the command.
```
hydroxide -smtp-port 2024 serve
2020/07/01 01:44:12 CardDAV server listening on 127.0.0.1:8080
2020/07/01 01:44:12 SMTP server listening on 127.0.0.1:2024
2020/07/01 01:44:12 IMAP server listening on 127.0.0.1:1143
```

The usage information should be changed to reflect this.
This commit is contained in:
Hubcapp 2020-07-01 00:51:03 -05:00 committed by Simon Ser
parent 74c2b8fa37
commit 246e71fbfe
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/hydroxide/main.go
View File

@ -109,7 +109,7 @@ func listenAndServeCardDAV(addr string, authManager *auth.Manager, eventsManager
return s.ListenAndServe() return s.ListenAndServe()
} }
const usage = `usage: hydroxide <command> <flags> const usage = `usage: hydroxide <flags> <command>
Commands: Commands:
auth <username> Login to ProtonMail via hydroxide auth <username> Login to ProtonMail via hydroxide
carddav Run hydroxide as a CardDAV server carddav Run hydroxide as a CardDAV server