jarno
/
hemppa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace traceback.print_exc() with logger.exception()

This commit is contained in:
gammafn 2021-05-04 23:56:06 -05:00
parent 321a20d721
commit 9fefb730a9
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bot.py
View File

@ -314,7 +314,7 @@ class Bot:
try: try:
module_settings[modulename] = moduleobject.get_settings() module_settings[modulename] = moduleobject.get_settings()
except Exception: except Exception:
traceback.print_exc(file=sys.stderr) self.logger.exception(f'unhandled exception {modulename}.get_settings')
data = {self.appid: self.version, 'module_settings': module_settings} data = {self.appid: self.version, 'module_settings': module_settings}
self.set_account_data(data) self.set_account_data(data)
@ -329,7 +329,7 @@ class Bot:
moduleobject.set_settings( moduleobject.set_settings(
data['module_settings'][modulename]) data['module_settings'][modulename])
except Exception: except Exception:
traceback.print_exc(file=sys.stderr) self.logger.exception(f'unhandled exception {modulename}.set_settings')
async def message_cb(self, room, event): async def message_cb(self, room, event):
# Ignore if asked to ignore # Ignore if asked to ignore
@ -373,7 +373,7 @@ class Bot:
await self.send_text(room, f'Sorry, only bot owner can run that command.') await self.send_text(room, f'Sorry, only bot owner can run that command.')
except Exception: except Exception:
await self.send_text(room, f'Module {command} experienced difficulty: {sys.exc_info()[0]} - see log for details') await self.send_text(room, f'Module {command} experienced difficulty: {sys.exc_info()[0]} - see log for details')
traceback.print_exc(file=sys.stderr) self.logger.exception(f'unhandled exception in !{command}')
else: else:
self.logger.error(f"Unknown command: {command}") self.logger.error(f"Unknown command: {command}")
# TODO Make this configurable # TODO Make this configurable
@ -415,8 +415,7 @@ class Bot:
cls = getattr(module, 'MatrixModule') cls = getattr(module, 'MatrixModule')
return cls(modulename) return cls(modulename)
except Exception: except Exception:
self.logger.error(f'Module {modulename} failed to load!') self.logger.exception(f'Module {modulename} failed to load')
traceback.print_exc(file=sys.stderr)
return None return None
def reload_modules(self): def reload_modules(self):
@ -446,7 +445,7 @@ class Bot:
try: try:
await moduleobject.matrix_poll(self, self.pollcount) await moduleobject.matrix_poll(self, self.pollcount)
except Exception: except Exception:
traceback.print_exc(file=sys.stderr) self.logger.exception(f'unhandled exception from {modulename}.matrix_poll')
await asyncio.sleep(10) await asyncio.sleep(10)
def set_account_data(self, data): def set_account_data(self, data):
@ -511,7 +510,7 @@ class Bot:
try: try:
moduleobject.matrix_start(self) moduleobject.matrix_start(self)
except Exception: except Exception:
traceback.print_exc(file=sys.stderr) self.logger.exception(f'unhandled exception from {modulename}.matrix_start')
self.logger.info(f'All modules started.') self.logger.info(f'All modules started.')
def stop(self): def stop(self):
@ -520,7 +519,7 @@ class Bot:
try: try:
moduleobject.matrix_stop(self) moduleobject.matrix_stop(self)
except Exception: except Exception:
traceback.print_exc(file=sys.stderr) self.logger.exception(f'unhandled exception from {modulename}.matrix_stop')
self.logger.info(f'All modules stopped.') self.logger.info(f'All modules stopped.')
async def run(self): async def run(self):