From a245ba3191ab0e9fd7b7ff39337fb81e71ef8ec3 Mon Sep 17 00:00:00 2001 From: Rafael Mardojai CM Date: Wed, 22 Nov 2023 10:48:30 -0500 Subject: [PATCH] lists: Fix unnecessary separation line in permissions list Firefox 121 enables the has() selector, now we ca use it to fix this issue. Fixes #654 --- theme/parts/lists.css | 15 +++++++++++++-- theme/parts/popups-contents.css | 1 - 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/theme/parts/lists.css b/theme/parts/lists.css index 0a196d3..dedca7b 100644 --- a/theme/parts/lists.css +++ b/theme/parts/lists.css @@ -22,15 +22,26 @@ richlistbox#items { } /* List item */ -.permission-popup-permission-list-anchor, +.permission-popup-permission-item, richlistbox#items richlistitem { padding: 6px !important; margin: 0 !important; } -.permission-popup-permission-list-anchor:not(:last-child), +.permission-popup-permission-list-anchor { + padding: 0 !important; +} +.permission-popup-permission-list-anchor:not(:has(.permission-popup-permission-item)) { + visibility: collapse; +} richlistbox#items richlistitem:not(:last-child) { border-bottom: 1px solid var(--gnome-card-shade-color); } +.permission-popup-permission-list-anchor:not(#permission-popup-permission-list-default-anchor):has(.permission-popup-permission-item) { + border-top: 1px solid var(--gnome-card-shade-color); +} +#permission-popup-permission-list-default-anchor:empty + .permission-popup-permission-list-anchor { + border: 0 !important; +} /* Fix list buttons on selected state */ @media (prefers-color-scheme: light) { diff --git a/theme/parts/popups-contents.css b/theme/parts/popups-contents.css index 6540ee4..08e5582 100644 --- a/theme/parts/popups-contents.css +++ b/theme/parts/popups-contents.css @@ -190,7 +190,6 @@ #permission-popup-permission-list-default-anchor:empty { padding: 0 !important; - border: 0 !important; } .permission-popup-permission-list-anchor[anchorfor="3rdPartyStorage"] { padding: 0 !important;