From d9e9568c2e9fbd855c3de266f6322660f265c714 Mon Sep 17 00:00:00 2001 From: ganfra Date: Thu, 23 Sep 2021 13:19:29 +0200 Subject: [PATCH] Clean code and update CHANGES --- changelog.d/4065.misc | 1 + vector/src/main/java/im/vector/app/core/di/VectorModule.kt | 3 --- .../home/room/detail/views/RoomDetailLazyLoadedViews.kt | 1 - .../im/vector/app/features/reactions/EmojiRecyclerAdapter.kt | 3 +-- 4 files changed, 2 insertions(+), 6 deletions(-) create mode 100644 changelog.d/4065.misc diff --git a/changelog.d/4065.misc b/changelog.d/4065.misc new file mode 100644 index 0000000000..35725f7fa1 --- /dev/null +++ b/changelog.d/4065.misc @@ -0,0 +1 @@ +Improve performances on RoomDetail screen \ No newline at end of file diff --git a/vector/src/main/java/im/vector/app/core/di/VectorModule.kt b/vector/src/main/java/im/vector/app/core/di/VectorModule.kt index 4d863f04d3..dd1ffee8ec 100644 --- a/vector/src/main/java/im/vector/app/core/di/VectorModule.kt +++ b/vector/src/main/java/im/vector/app/core/di/VectorModule.kt @@ -34,9 +34,7 @@ import im.vector.app.features.pin.SharedPrefPinCodeStore import im.vector.app.features.ui.SharedPreferencesUiStateRepository import im.vector.app.features.ui.UiStateRepository import kotlinx.coroutines.CoroutineScope -import kotlinx.coroutines.DelicateCoroutinesApi import kotlinx.coroutines.Dispatchers -import kotlinx.coroutines.GlobalScope import kotlinx.coroutines.SupervisorJob import org.matrix.android.sdk.api.Matrix import org.matrix.android.sdk.api.auth.AuthenticationService @@ -107,7 +105,6 @@ abstract class VectorModule { fun providesApplicationCoroutineScope(): CoroutineScope { return CoroutineScope(SupervisorJob() + Dispatchers.Main) } - } @Binds diff --git a/vector/src/main/java/im/vector/app/features/home/room/detail/views/RoomDetailLazyLoadedViews.kt b/vector/src/main/java/im/vector/app/features/home/room/detail/views/RoomDetailLazyLoadedViews.kt index 708f23aba1..fafb49ad5c 100644 --- a/vector/src/main/java/im/vector/app/features/home/room/detail/views/RoomDetailLazyLoadedViews.kt +++ b/vector/src/main/java/im/vector/app/features/home/room/detail/views/RoomDetailLazyLoadedViews.kt @@ -20,7 +20,6 @@ import android.view.View import android.view.ViewStub import im.vector.app.core.ui.views.FailedMessagesWarningView import im.vector.app.databinding.FragmentRoomDetailBinding -import im.vector.app.features.home.room.detail.composer.VoiceMessageRecorderView import im.vector.app.features.invite.VectorInviteView import kotlin.reflect.KMutableProperty0 diff --git a/vector/src/main/java/im/vector/app/features/reactions/EmojiRecyclerAdapter.kt b/vector/src/main/java/im/vector/app/features/reactions/EmojiRecyclerAdapter.kt index 5fbd02e75f..d64ee0f705 100644 --- a/vector/src/main/java/im/vector/app/features/reactions/EmojiRecyclerAdapter.kt +++ b/vector/src/main/java/im/vector/app/features/reactions/EmojiRecyclerAdapter.kt @@ -32,7 +32,6 @@ import androidx.transition.AutoTransition import androidx.transition.TransitionManager import im.vector.app.R import im.vector.app.features.reactions.data.EmojiData -import im.vector.app.features.reactions.data.EmojiDataSource import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch @@ -64,7 +63,7 @@ class EmojiRecyclerAdapter @Inject constructor() : } @SuppressLint("NotifyDataSetChanged") - fun update(emojiData: EmojiData){ + fun update(emojiData: EmojiData) { rawData = emojiData notifyDataSetChanged() }