From 51a95554d7b4043e364a986ffe1fb815ad7379fa Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Thu, 5 Nov 2020 18:30:00 +0100 Subject: [PATCH 1/3] Remove useless code. We can now inject element in the Fragment constructors --- .../java/im/vector/app/core/platform/VectorBaseFragment.kt | 3 --- 1 file changed, 3 deletions(-) diff --git a/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt b/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt index 179e21a6d8..cd38f5aeaa 100644 --- a/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt +++ b/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt @@ -97,12 +97,9 @@ abstract class VectorBaseFragment : BaseMvRxFragment(), HasScreenInjector { unrecognizedCertificateDialog = screenComponent.unrecognizedCertificateDialog() viewModelFactory = screenComponent.viewModelFactory() childFragmentManager.fragmentFactory = screenComponent.fragmentFactory() - injectWith(injector()) super.onAttach(context) } - protected open fun injectWith(injector: ScreenComponent) = Unit - @CallSuper override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) From c34750bdabdd607c17bfb95b25b6101eecbf626a Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 9 Nov 2020 16:49:31 +0100 Subject: [PATCH 2/3] Add Onuray in the core team authors --- AUTHORS.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/AUTHORS.md b/AUTHORS.md index 4fb5b8c994..f6ff724fec 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -26,6 +26,11 @@ Even if we try to be able to work on all the functionalities, we have more knowl - Product manager, Android developer - Specialist on the crypto implementation. +## Onuray: Android developer + +[@onurays:matrix.org](https://matrix.to/#/@onurays:matrix.org) +- Android developer + # Other contributors First of all, we thank all contributors who use Element and report problems on this GitHub project or via the integrated rageshake function. From 16448c0bc5eac8ccfe5520fa33ff69962e200edd Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 9 Nov 2020 16:53:17 +0100 Subject: [PATCH 3/3] Add Github link to the authors --- AUTHORS.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/AUTHORS.md b/AUTHORS.md index f6ff724fec..823dbc7311 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -4,7 +4,7 @@ A full developer contributors list can be found [here](https://github.com/vector Even if we try to be able to work on all the functionalities, we have more knowledge about what we have developed ourselves. -## Benoit: Android team leader +## [Benoit](https://github.com/bmarty): Android team leader [@benoit.marty:matrix.org](https://matrix.to/#/@benoit.marty:matrix.org) - Android team leader and project leader, Android developer, GitHub community manager. @@ -12,7 +12,7 @@ Even if we try to be able to work on all the functionalities, we have more knowl - Reviewing and polishing developed features, code quality manager, PRs reviewer, GitHub community manager. - Release manager on the Play Store -## François: Software architect +## [Ganfra](https://github.com/ganfra) (aka François): Software architect [@ganfra:matrix.org](https://matrix.to/#/@ganfra:matrix.org) - Software architect, Android developer @@ -20,13 +20,13 @@ Even if we try to be able to work on all the functionalities, we have more knowl - Work mainly on the global architecture of the project. - Specialist of the timeline, and lots of other features. -## Valere: Product manager, Android developer +## [Valere](https://github.com/BillCarsonFr): Product manager, Android developer [@valere35:matrix.org](https://matrix.to/#/@valere35:matrix.org) - Product manager, Android developer - Specialist on the crypto implementation. -## Onuray: Android developer +## [Onuray](https://github.com/onurays): Android developer [@onurays:matrix.org](https://matrix.to/#/@onurays:matrix.org) - Android developer