jarno
/
element-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Code review

This commit is contained in:
valere 2023-05-31 12:18:27 +02:00
parent dc969f502a
commit 8c1938987b
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vector/src/main/java/im/vector/app/features/crypto/verification/self/SelfVerificationViewModel.kt
View File

@ -147,7 +147,7 @@ class SelfVerificationViewModel @AssistedInject constructor(
}
setState { copy(hasAnyOtherSession = Loading()) }
viewModelScope.launch(Dispatchers.IO) {
viewModelScope.launch {
val hasAnyOtherSession = session.cryptoService()
.getCryptoDeviceInfo(session.myUserId)
.any {

4
vector/src/test/java/im/vector/app/core/device/DefaultGetDeviceInfoUseCaseTest.kt
View File

@ -19,7 +19,7 @@ package im.vector.app.core.device
import im.vector.app.test.fakes.FakeActiveSessionHolder
import im.vector.app.test.fakes.FakeCryptoService
import im.vector.app.test.fakes.FakeSession
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.test.runTest
import org.amshove.kluent.shouldBeEqualTo
import org.junit.Test
@ -33,7 +33,7 @@ class DefaultGetDeviceInfoUseCaseTest {
@Test
fun `when execute, then get crypto device info`() {
val result = runBlocking { getDeviceInfoUseCase.execute() }
val result = runTest { getDeviceInfoUseCase.execute() }
result shouldBeEqualTo cryptoService.cryptoDeviceInfo
}

4
vector/src/test/java/im/vector/app/core/pushers/PushersManagerTest.kt
View File

@ -29,7 +29,7 @@ import im.vector.app.test.fixtures.CryptoDeviceInfoFixture.aCryptoDeviceInfo
import im.vector.app.test.fixtures.PusherFixture
import im.vector.app.test.fixtures.SessionParamsFixture
import io.mockk.mockk
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.test.runTest
import org.amshove.kluent.shouldBeEqualTo
import org.junit.Test
import org.matrix.android.sdk.api.session.crypto.model.UnsignedDeviceInfo
@ -81,7 +81,7 @@ class PushersManagerTest {
withEventIdOnly = true,
)
runBlocking {
runTest {
pushersManager.enqueueRegisterPusher(pushKey, gateway)
}