jarno
/
element-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Detekt: fix FunctionParameterNaming

This commit is contained in:
Benoit Marty 2022-05-12 17:56:05 +02:00
parent c303b9afd3
commit 6f3b9c78b0
3 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/detekt/detekt.yml
View File

@ -61,9 +61,6 @@ complexity:
active: false active: false
naming: naming:
FunctionParameterNaming:
# TODO Enable it
active: false
VariableNaming: VariableNaming:
# TODO Enable it # TODO Enable it
active: false active: false

4
vector/src/main/java/im/vector/app/features/onboarding/Login2Variant.kt
View File

@ -309,9 +309,9 @@ class Login2Variant(
activity.finish() activity.finish()
} }
private fun updateWithState(LoginViewState2: LoginViewState2) { private fun updateWithState(loginViewState2: LoginViewState2) {
// Loading // Loading
setIsLoading(LoginViewState2.isLoading) setIsLoading(loginViewState2.isLoading)
} }
// Hack for AccountCreatedFragment // Hack for AccountCreatedFragment

8
vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthVariant.kt
View File

@ -288,8 +288,8 @@ class FtueAuthVariant(
.show() .show()
} }
private fun onServerSelectionDone(OnboardingViewEvents: OnboardingViewEvents.OnServerSelectionDone) { private fun onServerSelectionDone(onboardingViewEvents: OnboardingViewEvents.OnServerSelectionDone) {
when (OnboardingViewEvents.serverType) { when (onboardingViewEvents.serverType) {
ServerType.MatrixOrg -> Unit // In this case, we wait for the login flow ServerType.MatrixOrg -> Unit // In this case, we wait for the login flow
ServerType.EMS, ServerType.EMS,
ServerType.Other -> activity.addFragmentToBackstack( ServerType.Other -> activity.addFragmentToBackstack(
@ -301,9 +301,9 @@ class FtueAuthVariant(
} }
} }
private fun onSignModeSelected(OnboardingViewEvents: OnboardingViewEvents.OnSignModeSelected) = withState(onboardingViewModel) { state -> private fun onSignModeSelected(onboardingViewEvents: OnboardingViewEvents.OnSignModeSelected) = withState(onboardingViewModel) { state ->
// state.signMode could not be ready yet. So use value from the ViewEvent // state.signMode could not be ready yet. So use value from the ViewEvent
when (OnboardingViewEvents.signMode) { when (onboardingViewEvents.signMode) {
SignMode.Unknown -> error("Sign mode has to be set before calling this method") SignMode.Unknown -> error("Sign mode has to be set before calling this method")
SignMode.SignUp -> Unit // This case is processed in handleOnboardingViewEvents SignMode.SignUp -> Unit // This case is processed in handleOnboardingViewEvents
SignMode.SignIn -> handleSignInSelected(state) SignMode.SignIn -> handleSignInSelected(state)