From 6d3df0d802c08845bb2f68235925b4966431a720 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Wed, 1 Dec 2021 22:13:21 +0100 Subject: [PATCH] Use `@id` and not `@+id` when referencing ids in layouts - ConstraintLayout --- .../layout/activity_debug_material_theme.xml | 2 +- tools/check/forbidden_strings_in_layout.txt | 3 ++ .../res/layout/activity_big_image_viewer.xml | 2 +- vector/src/main/res/layout/activity_call.xml | 4 +- .../res/layout/activity_call_transfer.xml | 4 +- .../res/layout/activity_filtered_rooms.xml | 2 +- .../res/layout/activity_incoming_share.xml | 2 +- .../src/main/res/layout/activity_search.xml | 2 +- .../res/layout/activity_vector_web_view.xml | 2 +- .../layout/alerter_incoming_call_layout.xml | 4 +- .../layout/alerter_verification_layout.xml | 2 +- .../res/layout/bottom_sheet_bootstrap.xml | 2 +- .../layout/bottom_sheet_space_settings.xml | 4 +- .../res/layout/bottom_sheet_verification.xml | 8 +-- ...composer_layout_constraint_set_compact.xml | 8 +-- ...omposer_layout_constraint_set_expanded.xml | 18 +++---- .../dialog_confirmation_with_reason.xml | 4 +- .../res/layout/dialog_import_e2e_keys.xml | 4 +- .../layout/fragment_attachments_preview.xml | 4 +- ...gment_bootstrap_enter_account_password.xml | 4 +- .../fragment_bootstrap_enter_passphrase.xml | 2 +- .../fragment_bootstrap_migrate_backup.xml | 2 +- .../res/layout/fragment_bootstrap_reauth.xml | 2 +- .../res/layout/fragment_bootstrap_waiting.xml | 2 +- .../res/layout/fragment_contacts_book.xml | 4 +- ...ent_create_direct_room_directory_users.xml | 4 +- .../main/res/layout/fragment_create_poll.xml | 4 +- .../main/res/layout/fragment_create_room.xml | 4 +- .../layout/fragment_deactivate_account.xml | 4 +- .../main/res/layout/fragment_home_detail.xml | 6 +-- .../main/res/layout/fragment_home_drawer.xml | 28 +++++----- .../res/layout/fragment_incoming_share.xml | 2 +- .../layout/fragment_join_rules_recycler.xml | 2 +- .../fragment_keys_backup_restore_from_key.xml | 10 ++-- ...nt_keys_backup_restore_from_passphrase.xml | 4 +- .../fragment_keys_backup_restore_success.xml | 6 +-- .../fragment_keys_backup_setup_step1.xml | 8 +-- .../fragment_keys_backup_setup_step2.xml | 4 +- .../layout/fragment_login_account_created.xml | 10 ++-- .../fragment_login_server_selection.xml | 28 +++++----- .../fragment_login_server_selection_2.xml | 12 ++--- ...fragment_login_signup_signin_selection.xml | 8 +-- .../main/res/layout/fragment_login_splash.xml | 48 ++++++++--------- .../res/layout/fragment_login_splash_2.xml | 48 ++++++++--------- .../main/res/layout/fragment_login_terms.xml | 6 +-- .../res/layout/fragment_login_terms_2.xml | 6 +-- .../res/layout/fragment_matrix_profile.xml | 2 +- .../fragment_matrix_to_room_space_card.xml | 2 +- .../layout/fragment_matrix_to_user_card.xml | 2 +- .../main/res/layout/fragment_public_rooms.xml | 2 +- .../fragment_recyclerview_with_search.xml | 2 +- .../main/res/layout/fragment_review_terms.xml | 2 +- .../main/res/layout/fragment_room_detail.xml | 18 +++---- .../layout/fragment_room_directory_picker.xml | 2 +- .../fragment_room_preview_no_preview.xml | 2 +- .../layout/fragment_room_setting_generic.xml | 4 +- .../main/res/layout/fragment_room_uploads.xml | 4 +- .../res/layout/fragment_space_add_rooms.xml | 4 +- .../layout/fragment_space_leave_advanced.xml | 2 +- .../res/layout/fragment_space_preview.xml | 4 +- .../layout/fragment_ssss_access_from_key.xml | 8 +-- .../fragment_ssss_access_from_passphrase.xml | 12 ++--- .../res/layout/fragment_user_code_show.xml | 4 +- .../res/layout/fragment_user_directory.xml | 6 +-- .../main/res/layout/fragment_user_list.xml | 10 ++-- .../res/layout/item_autocomplete_command.xml | 2 +- .../res/layout/item_bottom_sheet_action.xml | 6 +-- .../item_bottom_sheet_message_preview.xml | 6 +-- .../layout/item_bottom_sheet_room_preview.xml | 14 ++--- .../res/layout/item_bottom_sheet_title.xml | 4 +- vector/src/main/res/layout/item_checkbox.xml | 2 +- .../main/res/layout/item_contact_detail.xml | 4 +- .../src/main/res/layout/item_contact_main.xml | 2 +- .../layout/item_create_direct_room_user.xml | 8 +-- .../main/res/layout/item_discovery_policy.xml | 4 +- .../main/res/layout/item_editable_avatar.xml | 4 +- .../src/main/res/layout/item_error_retry.xml | 2 +- .../res/layout/item_expandable_textview.xml | 4 +- .../src/main/res/layout/item_form_switch.xml | 10 ++-- .../res/layout/item_generic_empty_state.xml | 4 +- .../src/main/res/layout/item_generic_list.xml | 26 +++++----- vector/src/main/res/layout/item_group.xml | 10 ++-- .../src/main/res/layout/item_help_footer.xml | 4 +- .../main/res/layout/item_invite_by_mail.xml | 8 +-- .../src/main/res/layout/item_known_user.xml | 8 +-- vector/src/main/res/layout/item_locale.xml | 4 +- .../res/layout/item_login_error_retry.xml | 2 +- .../layout/item_notification_troubleshoot.xml | 14 ++--- vector/src/main/res/layout/item_policy.xml | 12 ++--- .../main/res/layout/item_profile_action.xml | 8 +-- .../res/layout/item_profile_matrix_item.xml | 14 ++--- .../item_profile_matrix_item_progress.xml | 6 +-- .../src/main/res/layout/item_public_room.xml | 22 ++++---- vector/src/main/res/layout/item_room.xml | 34 ++++++------ .../main/res/layout/item_room_directory.xml | 6 +-- .../res/layout/item_room_directory_server.xml | 4 +- .../main/res/layout/item_room_invitation.xml | 20 +++---- .../main/res/layout/item_room_placeholder.xml | 4 +- .../res/layout/item_room_to_add_in_space.xml | 2 +- .../layout/item_room_to_manage_in_space.xml | 4 +- .../main/res/layout/item_search_result.xml | 10 ++-- .../item_settings_button_single_line.xml | 2 +- .../res/layout/item_settings_edit_text.xml | 2 +- .../res/layout/item_settings_three_pid.xml | 6 +-- vector/src/main/res/layout/item_space.xml | 20 +++---- vector/src/main/res/layout/item_space_add.xml | 2 +- .../main/res/layout/item_space_roomchild.xml | 14 ++--- .../main/res/layout/item_space_subspace.xml | 2 +- .../res/layout/item_space_top_summary.xml | 6 +-- vector/src/main/res/layout/item_sub_space.xml | 8 +-- .../main/res/layout/item_suggested_room.xml | 10 ++-- .../res/layout/item_timeline_event_base.xml | 6 +-- .../layout/item_timeline_event_base_state.xml | 2 +- .../item_timeline_event_call_tile_stub.xml | 4 +- .../layout/item_timeline_event_file_stub.xml | 8 +-- ...item_timeline_event_media_message_stub.xml | 2 +- ...item_timeline_event_merged_header_stub.xml | 2 +- .../layout/item_timeline_event_voice_stub.xml | 2 +- vector/src/main/res/layout/item_tos.xml | 4 +- .../src/main/res/layout/item_unknown_room.xml | 2 +- .../src/main/res/layout/item_uploads_file.xml | 14 ++--- vector/src/main/res/layout/item_user.xml | 8 +-- .../res/layout/item_verification_action.xml | 12 ++--- .../res/layout/item_verification_wait.xml | 4 +- .../res/layout/item_verification_waiting.xml | 2 +- .../main/res/layout/vector_invite_view.xml | 4 +- .../view_bottom_sheet_action_button.xml | 16 +++--- .../layout/view_failed_messages_warning.xml | 2 +- .../res/layout/view_keys_backup_banner.xml | 8 +-- vector/src/main/res/layout/view_state.xml | 2 +- .../view_stub_room_member_profile_header.xml | 28 +++++----- .../layout/view_stub_room_profile_header.xml | 16 +++--- .../src/main/res/layout/view_url_preview.xml | 16 +++--- .../res/xml/motion_scene_notifs_fab_menu.xml | 52 +++++++++---------- 134 files changed, 515 insertions(+), 512 deletions(-) diff --git a/library/ui-styles/src/debug/res/layout/activity_debug_material_theme.xml b/library/ui-styles/src/debug/res/layout/activity_debug_material_theme.xml index 4828810e34..10107df9b2 100644 --- a/library/ui-styles/src/debug/res/layout/activity_debug_material_theme.xml +++ b/library/ui-styles/src/debug/res/layout/activity_debug_material_theme.xml @@ -34,7 +34,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout"> + app:layout_constraintTop_toBottomOf="@id/appBarLayout"> \ No newline at end of file diff --git a/vector/src/main/res/layout/activity_call.xml b/vector/src/main/res/layout/activity_call.xml index 342ae11562..a4a6f4a674 100644 --- a/vector/src/main/res/layout/activity_call.xml +++ b/vector/src/main/res/layout/activity_call.xml @@ -33,10 +33,10 @@ android:id="@+id/pipContainer" android:layout_width="0dp" android:layout_height="0dp" - app:layout_constraintBottom_toTopOf="@+id/callControlsView" + app:layout_constraintBottom_toTopOf="@id/callControlsView" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/callToolbar"> + app:layout_constraintTop_toBottomOf="@id/callToolbar"> @@ -65,7 +65,7 @@ android:layout_height="wrap_content" android:layout_centerVertical="true" android:layout_marginEnd="8dp" - android:layout_toStartOf="@+id/callTransferConnectAction" + android:layout_toStartOf="@id/callTransferConnectAction" android:layout_toEndOf="@id/callTransferConsultCheckBox" android:ellipsize="end" android:text="@string/call_transfer_consult_first" /> diff --git a/vector/src/main/res/layout/activity_filtered_rooms.xml b/vector/src/main/res/layout/activity_filtered_rooms.xml index 270de8f514..07a2bc7a2e 100644 --- a/vector/src/main/res/layout/activity_filtered_rooms.xml +++ b/vector/src/main/res/layout/activity_filtered_rooms.xml @@ -39,7 +39,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" /> + app:layout_constraintTop_toBottomOf="@id/appBarLayout" /> diff --git a/vector/src/main/res/layout/activity_incoming_share.xml b/vector/src/main/res/layout/activity_incoming_share.xml index f0e0c0a485..0de417f57b 100644 --- a/vector/src/main/res/layout/activity_incoming_share.xml +++ b/vector/src/main/res/layout/activity_incoming_share.xml @@ -39,7 +39,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" /> + app:layout_constraintTop_toBottomOf="@id/appBarLayout" /> diff --git a/vector/src/main/res/layout/activity_search.xml b/vector/src/main/res/layout/activity_search.xml index 7c71217f64..6f8980c656 100644 --- a/vector/src/main/res/layout/activity_search.xml +++ b/vector/src/main/res/layout/activity_search.xml @@ -39,7 +39,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" /> + app:layout_constraintTop_toBottomOf="@id/appBarLayout" /> diff --git a/vector/src/main/res/layout/activity_vector_web_view.xml b/vector/src/main/res/layout/activity_vector_web_view.xml index d691f4de5d..a8d1521159 100644 --- a/vector/src/main/res/layout/activity_vector_web_view.xml +++ b/vector/src/main/res/layout/activity_vector_web_view.xml @@ -25,7 +25,7 @@ android:layout_width="match_parent" android:layout_height="0dp" app:layout_constraintBottom_toBottomOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" /> + app:layout_constraintTop_toBottomOf="@id/appBarLayout" /> @@ -48,7 +48,7 @@ android:maxLines="1" android:textColor="?vctr_content_secondary" app:drawableTint="?vctr_content_secondary" - app:layout_constraintEnd_toStartOf="@+id/incomingCallRejectView" + app:layout_constraintEnd_toStartOf="@id/incomingCallRejectView" app:layout_constraintStart_toStartOf="@id/incomingCallNameView" app:layout_constraintTop_toBottomOf="@id/incomingCallNameView" tools:drawableStart="@drawable/ic_call_audio_small" diff --git a/vector/src/main/res/layout/alerter_verification_layout.xml b/vector/src/main/res/layout/alerter_verification_layout.xml index 86dcd41340..452e03c1ce 100644 --- a/vector/src/main/res/layout/alerter_verification_layout.xml +++ b/vector/src/main/res/layout/alerter_verification_layout.xml @@ -14,7 +14,7 @@ android:layout_height="40dp" android:importantForAccessibility="no" app:layout_constraintBottom_toBottomOf="parent" - app:layout_constraintEnd_toStartOf="@+id/alerter_texts" + app:layout_constraintEnd_toStartOf="@id/alerter_texts" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" tools:src="@sample/user_round_avatars" /> diff --git a/vector/src/main/res/layout/bottom_sheet_bootstrap.xml b/vector/src/main/res/layout/bottom_sheet_bootstrap.xml index 52784bc6af..c3fa9d2931 100644 --- a/vector/src/main/res/layout/bottom_sheet_bootstrap.xml +++ b/vector/src/main/res/layout/bottom_sheet_bootstrap.xml @@ -41,7 +41,7 @@ android:textStyle="bold" app:layout_constraintBottom_toBottomOf="@id/bootstrapIcon" app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintStart_toEndOf="@+id/bootstrapIcon" + app:layout_constraintStart_toEndOf="@id/bootstrapIcon" app:layout_constraintTop_toTopOf="@id/bootstrapIcon" tools:text="@string/bottom_sheet_setup_secure_backup_title" /> diff --git a/vector/src/main/res/layout/bottom_sheet_space_settings.xml b/vector/src/main/res/layout/bottom_sheet_space_settings.xml index 33b879ae45..d90a443717 100644 --- a/vector/src/main/res/layout/bottom_sheet_space_settings.xml +++ b/vector/src/main/res/layout/bottom_sheet_space_settings.xml @@ -37,7 +37,7 @@ android:textColor="?vctr_content_primary" android:textStyle="bold" app:layout_constrainedWidth="true" - app:layout_constraintBottom_toTopOf="@+id/spaceDescription" + app:layout_constraintBottom_toTopOf="@id/spaceDescription" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@id/spaceAvatarImageView" app:layout_constraintTop_toTopOf="parent" @@ -60,7 +60,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@id/spaceAvatarImageView" - app:layout_constraintTop_toBottomOf="@+id/spaceNameView" + app:layout_constraintTop_toBottomOf="@id/spaceNameView" tools:text="@sample/spaces.json/data/topic" tools:visibility="visible" /> diff --git a/vector/src/main/res/layout/bottom_sheet_verification.xml b/vector/src/main/res/layout/bottom_sheet_verification.xml index dc1fec20ef..b577eed154 100644 --- a/vector/src/main/res/layout/bottom_sheet_verification.xml +++ b/vector/src/main/res/layout/bottom_sheet_verification.xml @@ -47,10 +47,10 @@ android:maxLines="2" android:textColor="?vctr_content_primary" android:textStyle="bold" - app:layout_constraintBottom_toBottomOf="@+id/otherUserAvatarImageView" + app:layout_constraintBottom_toBottomOf="@id/otherUserAvatarImageView" app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintStart_toEndOf="@+id/otherUserAvatarImageView" - app:layout_constraintTop_toTopOf="@+id/otherUserAvatarImageView" + app:layout_constraintStart_toEndOf="@id/otherUserAvatarImageView" + app:layout_constraintTop_toTopOf="@id/otherUserAvatarImageView" tools:text="@string/verification_verify_user" /> + app:layout_constraintTop_toBottomOf="@id/otherUserAvatarImageView" /> diff --git a/vector/src/main/res/layout/composer_layout_constraint_set_compact.xml b/vector/src/main/res/layout/composer_layout_constraint_set_compact.xml index f42551d39a..3378878ac6 100644 --- a/vector/src/main/res/layout/composer_layout_constraint_set_compact.xml +++ b/vector/src/main/res/layout/composer_layout_constraint_set_compact.xml @@ -115,7 +115,7 @@ android:contentDescription="@string/option_send_files" android:src="@drawable/ic_attachment" app:layout_constraintBottom_toBottomOf="@id/sendButton" - app:layout_constraintEnd_toStartOf="@+id/composerEditTextOuterBorder" + app:layout_constraintEnd_toStartOf="@id/composerEditTextOuterBorder" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="@id/sendButton" app:layout_goneMarginBottom="57dp" @@ -142,8 +142,8 @@ android:nextFocusLeft="@id/composerEditText" android:nextFocusUp="@id/composerEditText" app:layout_constraintBottom_toBottomOf="parent" - app:layout_constraintEnd_toStartOf="@+id/composerEmojiButton" - app:layout_constraintStart_toStartOf="@+id/composerEditTextOuterBorder" + app:layout_constraintEnd_toStartOf="@id/composerEmojiButton" + app:layout_constraintStart_toStartOf="@id/composerEditTextOuterBorder" app:layout_constraintTop_toTopOf="parent" tools:text="@tools:sample/lorem/random" /> @@ -156,7 +156,7 @@ android:contentDescription="@string/a11y_open_emoji_picker" android:src="@drawable/ic_insert_emoji" app:layout_constraintBottom_toBottomOf="@id/attachmentButton" - app:layout_constraintEnd_toEndOf="@+id/composerEditTextOuterBorder" + app:layout_constraintEnd_toEndOf="@id/composerEditTextOuterBorder" app:layout_constraintStart_toEndOf="@id/composerEditText" app:layout_constraintTop_toTopOf="@id/attachmentButton" app:layout_goneMarginEnd="8dp" diff --git a/vector/src/main/res/layout/composer_layout_constraint_set_expanded.xml b/vector/src/main/res/layout/composer_layout_constraint_set_expanded.xml index d6a5b57884..8057957941 100644 --- a/vector/src/main/res/layout/composer_layout_constraint_set_expanded.xml +++ b/vector/src/main/res/layout/composer_layout_constraint_set_expanded.xml @@ -23,7 +23,7 @@ android:layout_height="1dp" android:background="?vctr_list_separator" app:layout_constraintEnd_toEndOf="@id/related_message_background" - app:layout_constraintStart_toStartOf="@+id/related_message_background" + app:layout_constraintStart_toStartOf="@id/related_message_background" app:layout_constraintTop_toTopOf="@id/related_message_background" /> @@ -60,8 +60,8 @@ android:importantForAccessibility="no" android:scaleType="centerCrop" android:visibility="gone" - app:layout_constraintStart_toStartOf="@+id/composerRelatedMessageTitle" - app:layout_constraintTop_toBottomOf="@+id/composerRelatedMessageTitle" + app:layout_constraintStart_toStartOf="@id/composerRelatedMessageTitle" + app:layout_constraintTop_toBottomOf="@id/composerRelatedMessageTitle" tools:ignore="MissingPrefix" tools:src="@tools:sample/backgrounds/scenic" tools:visibility="visible" /> @@ -127,9 +127,9 @@ android:background="?android:attr/selectableItemBackground" android:contentDescription="@string/option_send_files" android:src="@drawable/ic_attachment" - app:layout_constraintBottom_toBottomOf="@+id/sendButton" + app:layout_constraintBottom_toBottomOf="@id/sendButton" app:layout_constraintEnd_toStartOf="parent" - app:layout_constraintTop_toTopOf="@+id/sendButton" + app:layout_constraintTop_toTopOf="@id/sendButton" tools:ignore="MissingPrefix" /> @@ -167,7 +167,7 @@ android:contentDescription="@string/a11y_open_emoji_picker" android:src="@drawable/ic_insert_emoji" app:layout_constraintBottom_toBottomOf="@id/sendButton" - app:layout_constraintEnd_toEndOf="@+id/composerEditTextOuterBorder" + app:layout_constraintEnd_toEndOf="@id/composerEditTextOuterBorder" app:layout_constraintStart_toEndOf="@id/composerEditText" app:layout_constraintTop_toTopOf="@id/sendButton" app:layout_goneMarginBottom="52dp" diff --git a/vector/src/main/res/layout/dialog_confirmation_with_reason.xml b/vector/src/main/res/layout/dialog_confirmation_with_reason.xml index 421c723d3a..d59cb6d917 100644 --- a/vector/src/main/res/layout/dialog_confirmation_with_reason.xml +++ b/vector/src/main/res/layout/dialog_confirmation_with_reason.xml @@ -26,7 +26,7 @@ android:checked="true" android:text="@string/delete_event_dialog_reason_checkbox" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/dialogConfirmationText" /> + app:layout_constraintTop_toBottomOf="@id/dialogConfirmationText" /> + app:layout_constraintTop_toBottomOf="@id/dialog_e2e_keys_passphrase_filename"> diff --git a/vector/src/main/res/layout/fragment_bootstrap_enter_account_password.xml b/vector/src/main/res/layout/fragment_bootstrap_enter_account_password.xml index 9b8d6918f4..49c2f6ed9d 100644 --- a/vector/src/main/res/layout/fragment_bootstrap_enter_account_password.xml +++ b/vector/src/main/res/layout/fragment_bootstrap_enter_account_password.xml @@ -25,7 +25,7 @@ android:layout_height="wrap_content" android:layout_marginTop="16dp" app:errorEnabled="true" - app:layout_constraintBottom_toTopOf="@+id/bootstrapPasswordButton" + app:layout_constraintBottom_toTopOf="@id/bootstrapPasswordButton" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/bootstrapDescriptionText"> @@ -51,6 +51,6 @@ android:text="@string/_continue" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintTop_toBottomOf="@+id/bootstrapAccountPasswordTil" /> + app:layout_constraintTop_toBottomOf="@id/bootstrapAccountPasswordTil" /> diff --git a/vector/src/main/res/layout/fragment_bootstrap_enter_passphrase.xml b/vector/src/main/res/layout/fragment_bootstrap_enter_passphrase.xml index 78782b0b45..46ec6dc2d4 100644 --- a/vector/src/main/res/layout/fragment_bootstrap_enter_passphrase.xml +++ b/vector/src/main/res/layout/fragment_bootstrap_enter_passphrase.xml @@ -71,7 +71,7 @@ android:text="@string/_continue" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintTop_toBottomOf="@+id/ssss_passphrase_enter_til" /> + app:layout_constraintTop_toBottomOf="@id/ssss_passphrase_enter_til" /> diff --git a/vector/src/main/res/layout/fragment_bootstrap_migrate_backup.xml b/vector/src/main/res/layout/fragment_bootstrap_migrate_backup.xml index 04f547d500..1cf4fb7fce 100644 --- a/vector/src/main/res/layout/fragment_bootstrap_migrate_backup.xml +++ b/vector/src/main/res/layout/fragment_bootstrap_migrate_backup.xml @@ -70,6 +70,6 @@ android:text="@string/_continue" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintTop_toBottomOf="@+id/bootstrapRecoveryKeyEnterTil" /> + app:layout_constraintTop_toBottomOf="@id/bootstrapRecoveryKeyEnterTil" /> diff --git a/vector/src/main/res/layout/fragment_bootstrap_reauth.xml b/vector/src/main/res/layout/fragment_bootstrap_reauth.xml index bb527db292..73cf0d2ab9 100644 --- a/vector/src/main/res/layout/fragment_bootstrap_reauth.xml +++ b/vector/src/main/res/layout/fragment_bootstrap_reauth.xml @@ -24,7 +24,7 @@ android:layout_height="wrap_content" android:layout_marginTop="16dp" app:layout_constraintBottom_toTopOf="@id/reAuthFailureText" - app:layout_constraintTop_toBottomOf="@+id/bootstrapDescriptionText" /> + app:layout_constraintTop_toBottomOf="@id/bootstrapDescriptionText" /> + app:layout_constraintTop_toBottomOf="@id/bootstrapDescriptionText" /> @@ -114,7 +114,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" + app:layout_constraintTop_toBottomOf="@id/appBarLayout" tools:listitem="@layout/item_contact_main" /> diff --git a/vector/src/main/res/layout/fragment_create_direct_room_directory_users.xml b/vector/src/main/res/layout/fragment_create_direct_room_directory_users.xml index 130186deed..85c92c5225 100644 --- a/vector/src/main/res/layout/fragment_create_direct_room_directory_users.xml +++ b/vector/src/main/res/layout/fragment_create_direct_room_directory_users.xml @@ -56,7 +56,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintHorizontal_bias="0.0" - app:layout_constraintStart_toEndOf="@+id/createDirectRoomClose" + app:layout_constraintStart_toEndOf="@id/createDirectRoomClose" app:layout_constraintTop_toTopOf="parent" /> @@ -92,7 +92,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" + app:layout_constraintTop_toBottomOf="@id/appBarLayout" tools:listitem="@layout/item_create_direct_room_user" /> diff --git a/vector/src/main/res/layout/fragment_create_poll.xml b/vector/src/main/res/layout/fragment_create_poll.xml index b82342558c..3a9baef270 100644 --- a/vector/src/main/res/layout/fragment_create_poll.xml +++ b/vector/src/main/res/layout/fragment_create_poll.xml @@ -52,7 +52,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintHorizontal_bias="0.0" - app:layout_constraintStart_toEndOf="@+id/createPollClose" + app:layout_constraintStart_toEndOf="@id/createPollClose" app:layout_constraintTop_toTopOf="parent" /> @@ -68,7 +68,7 @@ android:overScrollMode="always" app:layout_behavior="@string/appbar_scrolling_view_behavior" app:layout_constraintBottom_toTopOf="@id/createPollButton" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" + app:layout_constraintTop_toBottomOf="@id/appBarLayout" tools:listitem="@layout/item_form_text_input_with_delete" />