From 5f68f98d3a327256f44e06be5480c8d2ba36c79f Mon Sep 17 00:00:00 2001 From: Valere Date: Wed, 11 Oct 2023 17:04:05 +0200 Subject: [PATCH] fix unit test --- .../settings/devices/v2/RefreshDevicesUseCaseTest.kt | 2 +- .../devices/v2/othersessions/OtherSessionsViewModelTest.kt | 7 +++++-- .../devices/v2/overview/SessionOverviewViewModelTest.kt | 4 ++++ .../settings/devices/v2/rename/RenameSessionUseCaseTest.kt | 2 +- 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/vector/src/test/java/im/vector/app/features/settings/devices/v2/RefreshDevicesUseCaseTest.kt b/vector/src/test/java/im/vector/app/features/settings/devices/v2/RefreshDevicesUseCaseTest.kt index 047ae28be7..a8dee9f178 100644 --- a/vector/src/test/java/im/vector/app/features/settings/devices/v2/RefreshDevicesUseCaseTest.kt +++ b/vector/src/test/java/im/vector/app/features/settings/devices/v2/RefreshDevicesUseCaseTest.kt @@ -35,7 +35,7 @@ class RefreshDevicesUseCaseTest { fun `given current session when refreshing then devices list and keys are fetched`() { val session = fakeActiveSessionHolder.fakeSession coEvery { session.cryptoService().fetchDevicesList() } returns emptyList() - coEvery { session.cryptoService().downloadKeysIfNeeded(any()) } returns MXUsersDevicesMap() + coEvery { session.cryptoService().downloadKeysIfNeeded(any(), any()) } returns MXUsersDevicesMap() runBlocking { refreshDevicesUseCase.execute() diff --git a/vector/src/test/java/im/vector/app/features/settings/devices/v2/othersessions/OtherSessionsViewModelTest.kt b/vector/src/test/java/im/vector/app/features/settings/devices/v2/othersessions/OtherSessionsViewModelTest.kt index 8b595d0ac5..ab4e1a222b 100644 --- a/vector/src/test/java/im/vector/app/features/settings/devices/v2/othersessions/OtherSessionsViewModelTest.kt +++ b/vector/src/test/java/im/vector/app/features/settings/devices/v2/othersessions/OtherSessionsViewModelTest.kt @@ -46,6 +46,7 @@ import org.junit.Before import org.junit.Ignore import org.junit.Rule import org.junit.Test +import org.matrix.android.sdk.api.session.homeserver.HomeServerCapabilities import org.matrix.android.sdk.api.session.uia.DefaultBaseAuth private const val A_DEVICE_ID_1 = "device-id-1" @@ -87,8 +88,10 @@ class OtherSessionsViewModelTest { // Needed for internal usage of Flow.throttleFirst() inside the ViewModel mockkStatic(SystemClock::class) every { SystemClock.elapsedRealtime() } returns 1234 - - givenVerificationService() + fakeActiveSessionHolder.fakeSession.fakeHomeServerCapabilitiesService.givenCapabilities( + HomeServerCapabilities() + ) + givenVerificationService().givenEventFlow() fakeVectorPreferences.givenSessionManagerShowIpAddress(false) } diff --git a/vector/src/test/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewViewModelTest.kt b/vector/src/test/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewViewModelTest.kt index ab99f71588..8fe68bdbf6 100644 --- a/vector/src/test/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewViewModelTest.kt +++ b/vector/src/test/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewViewModelTest.kt @@ -52,6 +52,7 @@ import org.junit.Ignore import org.junit.Rule import org.junit.Test import org.matrix.android.sdk.api.session.crypto.model.RoomEncryptionTrustLevel +import org.matrix.android.sdk.api.session.homeserver.HomeServerCapabilities import org.matrix.android.sdk.api.session.uia.DefaultBaseAuth private const val A_SESSION_ID_1 = "session-id-1" @@ -101,6 +102,9 @@ class SessionOverviewViewModelTest { mockkStatic(SystemClock::class) every { SystemClock.elapsedRealtime() } returns 1234 + fakeActiveSessionHolder.fakeSession.fakeHomeServerCapabilitiesService.givenCapabilities( + HomeServerCapabilities() + ) givenVerificationService() fakeGetNotificationsStatusUseCase.givenExecuteReturns( fakeActiveSessionHolder.fakeSession, diff --git a/vector/src/test/java/im/vector/app/features/settings/devices/v2/rename/RenameSessionUseCaseTest.kt b/vector/src/test/java/im/vector/app/features/settings/devices/v2/rename/RenameSessionUseCaseTest.kt index 92ef81e56b..d52504e80e 100644 --- a/vector/src/test/java/im/vector/app/features/settings/devices/v2/rename/RenameSessionUseCaseTest.kt +++ b/vector/src/test/java/im/vector/app/features/settings/devices/v2/rename/RenameSessionUseCaseTest.kt @@ -43,7 +43,7 @@ class RenameSessionUseCaseTest { fun `given a device id and a new name when no error during rename then the device is renamed with success`() = runTest { // Given fakeActiveSessionHolder.fakeSession.fakeCryptoService.givenSetDeviceNameSucceeds() - coVerify { refreshDevicesUseCase.execute() } + coEvery { refreshDevicesUseCase.execute() } returns Unit // When val result = renameSessionUseCase.execute(A_DEVICE_ID, A_DEVICE_NAME)