diff --git a/changelog.d/4604.misc b/changelog.d/4604.misc new file mode 100644 index 0000000000..2a3d3f70c3 --- /dev/null +++ b/changelog.d/4604.misc @@ -0,0 +1 @@ +Cleanup the layout files \ No newline at end of file diff --git a/library/ui-styles/src/debug/res/layout/activity_debug_material_theme.xml b/library/ui-styles/src/debug/res/layout/activity_debug_material_theme.xml index 4828810e34..c1ae9ef117 100644 --- a/library/ui-styles/src/debug/res/layout/activity_debug_material_theme.xml +++ b/library/ui-styles/src/debug/res/layout/activity_debug_material_theme.xml @@ -34,7 +34,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout"> + app:layout_constraintTop_toBottomOf="@id/appBarLayout"> - visible - diff --git a/library/ui-styles/src/main/res/transition/image_preview_transition.xml b/library/ui-styles/src/main/res/transition/image_preview_transition.xml index 3674324c4e..c1af6d7973 100644 --- a/library/ui-styles/src/main/res/transition/image_preview_transition.xml +++ b/library/ui-styles/src/main/res/transition/image_preview_transition.xml @@ -11,5 +11,3 @@ - - diff --git a/library/ui-styles/src/main/res/values/dimens.xml b/library/ui-styles/src/main/res/values/dimens.xml index e2e50449ce..519920786c 100644 --- a/library/ui-styles/src/main/res/values/dimens.xml +++ b/library/ui-styles/src/main/res/values/dimens.xml @@ -32,7 +32,6 @@ 88dp 8dp - 76dp @@ -40,5 +39,4 @@ 320dp - \ No newline at end of file diff --git a/library/ui-styles/src/main/res/values/palette.xml b/library/ui-styles/src/main/res/values/palette.xml index ed12f10af3..e37fd8a7c6 100644 --- a/library/ui-styles/src/main/res/values/palette.xml +++ b/library/ui-styles/src/main/res/values/palette.xml @@ -20,7 +20,6 @@ #5C56F5 #0086E6 - #F4F6FA #E3E8F0 diff --git a/library/ui-styles/src/main/res/values/stylable_badge_floating_action_button.xml b/library/ui-styles/src/main/res/values/stylable_badge_floating_action_button.xml index c9be5175e0..88bee99f84 100644 --- a/library/ui-styles/src/main/res/values/stylable_badge_floating_action_button.xml +++ b/library/ui-styles/src/main/res/values/stylable_badge_floating_action_button.xml @@ -1,5 +1,4 @@ - diff --git a/library/ui-styles/src/main/res/values/styles_social_login.xml b/library/ui-styles/src/main/res/values/styles_social_login.xml index f601f36480..5a76f70f2e 100644 --- a/library/ui-styles/src/main/res/values/styles_social_login.xml +++ b/library/ui-styles/src/main/res/values/styles_social_login.xml @@ -49,7 +49,6 @@ @android:color/black - @@ -68,7 +67,6 @@ #3877EA - @@ -85,7 +83,6 @@ #5D9EC9 - @@ -118,5 +115,4 @@ @android:color/black - \ No newline at end of file diff --git a/tools/check/forbidden_strings_in_layout.txt b/tools/check/forbidden_strings_in_layout.txt index 09f0d01f69..545983f844 100644 --- a/tools/check/forbidden_strings_in_layout.txt +++ b/tools/check/forbidden_strings_in_layout.txt @@ -25,3 +25,8 @@ ### Use style="@style/Widget.Vector.TextView.*" instead of textSize attribute android:textSize===9 + +### Use `@id` and not `@+id` when referencing ids in layouts +layout_(.*)="@\+id +accessibilityTraversal(.*)="@\+id +toolbarId="@\+id diff --git a/tools/templates/ElementFeature/template.xml b/tools/templates/ElementFeature/template.xml index 14c718c993..71cf74f19b 100644 --- a/tools/templates/ElementFeature/template.xml +++ b/tools/templates/ElementFeature/template.xml @@ -105,8 +105,6 @@ suggest="${underscoreToCamelCase(classToResource(fragmentClass))}ViewEvents" default="MainViewEvents" help="The name of the view events to create" /> - - - - - - - \ No newline at end of file diff --git a/vector/src/main/res/drawable/bg_rounded_button.xml b/vector/src/main/res/drawable/bg_rounded_button.xml index 4b5503a92f..a316195792 100644 --- a/vector/src/main/res/drawable/bg_rounded_button.xml +++ b/vector/src/main/res/drawable/bg_rounded_button.xml @@ -1,5 +1,4 @@ - diff --git a/vector/src/main/res/drawable/bg_tombstone_predecessor.xml b/vector/src/main/res/drawable/bg_tombstone_predecessor.xml index 65c214d2cd..4b7a8d2d4f 100644 --- a/vector/src/main/res/drawable/bg_tombstone_predecessor.xml +++ b/vector/src/main/res/drawable/bg_tombstone_predecessor.xml @@ -18,5 +18,4 @@ - \ No newline at end of file diff --git a/vector/src/main/res/drawable/bg_unread_notification.xml b/vector/src/main/res/drawable/bg_unread_notification.xml index 2b6c1051ca..7c9ea18eec 100644 --- a/vector/src/main/res/drawable/bg_unread_notification.xml +++ b/vector/src/main/res/drawable/bg_unread_notification.xml @@ -1,5 +1,4 @@ - diff --git a/vector/src/main/res/drawable/highlighted_message_background.xml b/vector/src/main/res/drawable/highlighted_message_background.xml index 10f745fb4d..9eeded4853 100644 --- a/vector/src/main/res/drawable/highlighted_message_background.xml +++ b/vector/src/main/res/drawable/highlighted_message_background.xml @@ -31,5 +31,4 @@ - \ No newline at end of file diff --git a/vector/src/main/res/layout/activity_big_image_viewer.xml b/vector/src/main/res/layout/activity_big_image_viewer.xml index 3865e26261..8f1cf88aff 100644 --- a/vector/src/main/res/layout/activity_big_image_viewer.xml +++ b/vector/src/main/res/layout/activity_big_image_viewer.xml @@ -25,7 +25,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" + app:layout_constraintTop_toBottomOf="@id/appBarLayout" app:optimizeDisplay="true" /> \ No newline at end of file diff --git a/vector/src/main/res/layout/activity_call.xml b/vector/src/main/res/layout/activity_call.xml index 342ae11562..2238f96c9f 100644 --- a/vector/src/main/res/layout/activity_call.xml +++ b/vector/src/main/res/layout/activity_call.xml @@ -1,8 +1,6 @@ - - + app:layout_constraintTop_toBottomOf="@id/callToolbar"> - @@ -65,7 +65,7 @@ android:layout_height="wrap_content" android:layout_centerVertical="true" android:layout_marginEnd="8dp" - android:layout_toStartOf="@+id/callTransferConnectAction" + android:layout_toStartOf="@id/callTransferConnectAction" android:layout_toEndOf="@id/callTransferConsultCheckBox" android:ellipsize="end" android:text="@string/call_transfer_consult_first" /> diff --git a/vector/src/main/res/layout/activity_filtered_rooms.xml b/vector/src/main/res/layout/activity_filtered_rooms.xml index 270de8f514..07a2bc7a2e 100644 --- a/vector/src/main/res/layout/activity_filtered_rooms.xml +++ b/vector/src/main/res/layout/activity_filtered_rooms.xml @@ -39,7 +39,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" /> + app:layout_constraintTop_toBottomOf="@id/appBarLayout" /> diff --git a/vector/src/main/res/layout/activity_home.xml b/vector/src/main/res/layout/activity_home.xml index a41256fb84..9899c15aa6 100644 --- a/vector/src/main/res/layout/activity_home.xml +++ b/vector/src/main/res/layout/activity_home.xml @@ -22,12 +22,10 @@ - - \ No newline at end of file diff --git a/vector/src/main/res/layout/activity_incoming_share.xml b/vector/src/main/res/layout/activity_incoming_share.xml index f0e0c0a485..0de417f57b 100644 --- a/vector/src/main/res/layout/activity_incoming_share.xml +++ b/vector/src/main/res/layout/activity_incoming_share.xml @@ -39,7 +39,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" /> + app:layout_constraintTop_toBottomOf="@id/appBarLayout" /> diff --git a/vector/src/main/res/layout/activity_main.xml b/vector/src/main/res/layout/activity_main.xml index f341a710fa..c7bca50acb 100644 --- a/vector/src/main/res/layout/activity_main.xml +++ b/vector/src/main/res/layout/activity_main.xml @@ -1,5 +1,4 @@ - - + app:layout_constraintTop_toBottomOf="@id/appBarLayout" /> diff --git a/vector/src/main/res/layout/activity_vector_web_view.xml b/vector/src/main/res/layout/activity_vector_web_view.xml index d691f4de5d..a8d1521159 100644 --- a/vector/src/main/res/layout/activity_vector_web_view.xml +++ b/vector/src/main/res/layout/activity_vector_web_view.xml @@ -25,7 +25,7 @@ android:layout_width="match_parent" android:layout_height="0dp" app:layout_constraintBottom_toBottomOf="parent" - app:layout_constraintTop_toBottomOf="@+id/appBarLayout" /> + app:layout_constraintTop_toBottomOf="@id/appBarLayout" /> @@ -48,7 +48,7 @@ android:maxLines="1" android:textColor="?vctr_content_secondary" app:drawableTint="?vctr_content_secondary" - app:layout_constraintEnd_toStartOf="@+id/incomingCallRejectView" + app:layout_constraintEnd_toStartOf="@id/incomingCallRejectView" app:layout_constraintStart_toStartOf="@id/incomingCallNameView" app:layout_constraintTop_toBottomOf="@id/incomingCallNameView" tools:drawableStart="@drawable/ic_call_audio_small" diff --git a/vector/src/main/res/layout/alerter_verification_layout.xml b/vector/src/main/res/layout/alerter_verification_layout.xml index 86dcd41340..d532a10dc2 100644 --- a/vector/src/main/res/layout/alerter_verification_layout.xml +++ b/vector/src/main/res/layout/alerter_verification_layout.xml @@ -14,7 +14,7 @@ android:layout_height="40dp" android:importantForAccessibility="no" app:layout_constraintBottom_toBottomOf="parent" - app:layout_constraintEnd_toStartOf="@+id/alerter_texts" + app:layout_constraintEnd_toStartOf="@id/alerter_texts" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" tools:src="@sample/user_round_avatars" /> @@ -26,7 +26,7 @@ android:layout_height="24dp" android:importantForAccessibility="no" android:src="@drawable/ic_shield_warning" - app:layout_constraintCircle="@+id/ivUserAvatar" + app:layout_constraintCircle="@id/ivUserAvatar" app:layout_constraintCircleAngle="135" app:layout_constraintCircleRadius="20dp" tools:ignore="MissingConstraints" diff --git a/vector/src/main/res/layout/bottom_sheet_add_rooms_or_spaces_to_space.xml b/vector/src/main/res/layout/bottom_sheet_add_rooms_or_spaces_to_space.xml index e80a55bc16..25c2d1c3e5 100644 --- a/vector/src/main/res/layout/bottom_sheet_add_rooms_or_spaces_to_space.xml +++ b/vector/src/main/res/layout/bottom_sheet_add_rooms_or_spaces_to_space.xml @@ -41,5 +41,4 @@ app:titleTextColor="?vctr_content_primary" tools:actionDescription="" /> - diff --git a/vector/src/main/res/layout/bottom_sheet_bootstrap.xml b/vector/src/main/res/layout/bottom_sheet_bootstrap.xml index 52784bc6af..c3fa9d2931 100644 --- a/vector/src/main/res/layout/bottom_sheet_bootstrap.xml +++ b/vector/src/main/res/layout/bottom_sheet_bootstrap.xml @@ -41,7 +41,7 @@ android:textStyle="bold" app:layout_constraintBottom_toBottomOf="@id/bootstrapIcon" app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintStart_toEndOf="@+id/bootstrapIcon" + app:layout_constraintStart_toEndOf="@id/bootstrapIcon" app:layout_constraintTop_toTopOf="@id/bootstrapIcon" tools:text="@string/bottom_sheet_setup_secure_backup_title" /> diff --git a/vector/src/main/res/layout/bottom_sheet_call_dialer_choice.xml b/vector/src/main/res/layout/bottom_sheet_call_dialer_choice.xml index f07e6fff8c..0539c648b4 100644 --- a/vector/src/main/res/layout/bottom_sheet_call_dialer_choice.xml +++ b/vector/src/main/res/layout/bottom_sheet_call_dialer_choice.xml @@ -24,5 +24,4 @@ app:tint="?vctr_content_primary" app:titleTextColor="?vctr_content_primary" /> - diff --git a/vector/src/main/res/layout/bottom_sheet_invited_to_space.xml b/vector/src/main/res/layout/bottom_sheet_invited_to_space.xml index 5686c8879e..a1ecf80dd5 100644 --- a/vector/src/main/res/layout/bottom_sheet_invited_to_space.xml +++ b/vector/src/main/res/layout/bottom_sheet_invited_to_space.xml @@ -33,7 +33,6 @@ app:layout_constraintTop_toTopOf="parent" tools:src="@sample/user_round_avatars" /> - - -