Test framework cleaning

This commit is contained in:
valere 2023-04-07 11:34:27 +02:00
parent 89267256ef
commit 1b12db9270
6 changed files with 22 additions and 24 deletions

View File

@ -87,15 +87,13 @@ class CommonTestHelper internal constructor(context: Context, val cryptoConfig:
internal fun runCryptoTest(context: Context, cryptoConfig: MXCryptoConfig? = null, autoSignoutOnClose: Boolean = true, block: suspend CoroutineScope.(CryptoTestHelper, CommonTestHelper) -> Unit) { internal fun runCryptoTest(context: Context, cryptoConfig: MXCryptoConfig? = null, autoSignoutOnClose: Boolean = true, block: suspend CoroutineScope.(CryptoTestHelper, CommonTestHelper) -> Unit) {
val testHelper = CommonTestHelper(context, cryptoConfig) val testHelper = CommonTestHelper(context, cryptoConfig)
val cryptoTestHelper = CryptoTestHelper(testHelper) val cryptoTestHelper = CryptoTestHelper(testHelper)
return try { return runTest(dispatchTimeoutMs = TestConstants.timeOutMillis) {
runTest(dispatchTimeoutMs = TestConstants.timeOutMillis * 2) { try {
withContext(Dispatchers.Main) { withContext(Dispatchers.Default) {
block(cryptoTestHelper, testHelper) block(cryptoTestHelper, testHelper)
} }
} } finally {
} finally { if (autoSignoutOnClose) {
if (autoSignoutOnClose) {
runBlocking {
testHelper.cleanUpOpenedSessions() testHelper.cleanUpOpenedSessions()
} }
} }

View File

@ -193,8 +193,8 @@ class KeyShareTests : InstrumentedTest {
cryptoTestHelper.ensureCanDecrypt(listOf(receivedEvent.eventId), aliceSession2, roomId, listOf(sentEventText ?: "")) cryptoTestHelper.ensureCanDecrypt(listOf(receivedEvent.eventId), aliceSession2, roomId, listOf(sentEventText ?: ""))
commonTestHelper.signOutAndClose(aliceSession) // commonTestHelper.signOutAndClose(aliceSession)
commonTestHelper.signOutAndClose(aliceSession2) // commonTestHelper.signOutAndClose(aliceSession2)
} }
// See E2ESanityTest for a test regarding secret sharing // See E2ESanityTest for a test regarding secret sharing
@ -272,8 +272,8 @@ class KeyShareTests : InstrumentedTest {
ownDeviceReply != null && ownDeviceReply.result is RequestResult.Success ownDeviceReply != null && ownDeviceReply.result is RequestResult.Success
} }
commonTestHelper.signOutAndClose(aliceSession) // commonTestHelper.signOutAndClose(aliceSession)
commonTestHelper.signOutAndClose(aliceNewSession) // commonTestHelper.signOutAndClose(aliceNewSession)
} }
@Test @Test
@ -387,9 +387,9 @@ class KeyShareTests : InstrumentedTest {
result != null && result is RequestResult.Success && result.chainIndex == 3 result != null && result is RequestResult.Success && result.chainIndex == 3
} }
commonTestHelper.signOutAndClose(aliceNewSession) // commonTestHelper.signOutAndClose(aliceNewSession)
commonTestHelper.signOutAndClose(aliceSession) // commonTestHelper.signOutAndClose(aliceSession)
commonTestHelper.signOutAndClose(bobSession) // commonTestHelper.signOutAndClose(bobSession)
} }
@Test @Test
@ -479,8 +479,8 @@ class KeyShareTests : InstrumentedTest {
val outgoing = aliceNewSession.cryptoService().getOutgoingRoomKeyRequests().firstOrNull { it.sessionId == sentEventMegolmSession } val outgoing = aliceNewSession.cryptoService().getOutgoingRoomKeyRequests().firstOrNull { it.sessionId == sentEventMegolmSession }
assertEquals("The request should be canceled", OutgoingRoomKeyRequestState.SENT_THEN_CANCELED, outgoing!!.state) assertEquals("The request should be canceled", OutgoingRoomKeyRequestState.SENT_THEN_CANCELED, outgoing!!.state)
commonTestHelper.signOutAndClose(aliceNewSession) // commonTestHelper.signOutAndClose(aliceNewSession)
commonTestHelper.signOutAndClose(aliceSession) // commonTestHelper.signOutAndClose(aliceSession)
commonTestHelper.signOutAndClose(bobSession) // commonTestHelper.signOutAndClose(bobSession)
} }
} }

View File

@ -88,7 +88,7 @@ class QuadSTests : InstrumentedTest {
assertNotNull(defaultKeyAccountData?.content) assertNotNull(defaultKeyAccountData?.content)
assertEquals("Unexpected default key ${defaultKeyAccountData?.content}", TEST_KEY_ID, defaultKeyAccountData?.content?.get("key")) assertEquals("Unexpected default key ${defaultKeyAccountData?.content}", TEST_KEY_ID, defaultKeyAccountData?.content?.get("key"))
testHelper.signOutAndClose(aliceSession) // testHelper.signOutAndClose(aliceSession)
} }
@Test @Test

View File

@ -300,8 +300,8 @@ class VerificationTest : InstrumentedTest {
requests.any { it.cancelConclusion == CancelCode.AcceptedByAnotherDevice } requests.any { it.cancelConclusion == CancelCode.AcceptedByAnotherDevice }
} }
testHelper.signOutAndClose(aliceSessionToVerify) // testHelper.signOutAndClose(aliceSessionToVerify)
testHelper.signOutAndClose(aliceSessionThatVerifies) // testHelper.signOutAndClose(aliceSessionThatVerifies)
testHelper.signOutAndClose(aliceSessionThatReceivesCanceledEvent) // testHelper.signOutAndClose(aliceSessionThatReceivesCanceledEvent)
} }
} }

View File

@ -124,8 +124,8 @@ class SpaceCreationTest : InstrumentedTest {
assertEquals("Room name should be set", roomName, spaceBobPov?.asRoom()?.roomSummary()?.name) assertEquals("Room name should be set", roomName, spaceBobPov?.asRoom()?.roomSummary()?.name)
assertEquals("Room topic should be set", topic, spaceBobPov?.asRoom()?.roomSummary()?.topic) assertEquals("Room topic should be set", topic, spaceBobPov?.asRoom()?.roomSummary()?.topic)
commonTestHelper.signOutAndClose(aliceSession) // commonTestHelper.signOutAndClose(aliceSession)
commonTestHelper.signOutAndClose(bobSession) // commonTestHelper.signOutAndClose(bobSession)
} }
@Test @Test

View File

@ -334,7 +334,7 @@ class SpaceHierarchyTest : InstrumentedTest {
} }
) )
commonTestHelper.signOutAndClose(session) // commonTestHelper.signOutAndClose(session)
} }
data class TestSpaceCreationResult( data class TestSpaceCreationResult(